Hide password in log #906
Hide password in log #906
Conversation
| new_str.replace_range(start..end, &"*".repeat(end - start)); | ||
| } | ||
| } | ||
| } else if let Some(pwd_idx) = conn_string.find("password=") { |
There was a problem hiding this comment.
Seems there's still a bug here
There was a problem hiding this comment.
no no, this is not a good way to do this. Regex is built specifically for this type of jobs, or a dedicated postgres connection string parser (which is part of the postgress connection lib, so hard to reuse in a better way). I did submit a better solution to this (IMO) - #907
In general for this type of issues, take a look at documentation -- I would use something like this, you can try it at https://rustexp.lpil.uk/
^postgres(?:ql)?://[^:@/?]+:([^:@/?]+)@ -- the password is captured as the first capture group
There was a problem hiding this comment.
I'm not good at Regex actually I don't like Regex. So glad to see that there is a dedicated parser in other crate lib. Closed.
There was a problem hiding this comment.
The reason I don't like Regex is it's easy to write hard to read later..
There was a problem hiding this comment.
it's not that bad, and it does save you in many cases, so highly advise to embrace it ... sparingly! ;)
There was a problem hiding this comment.
TBH, I don't think the code of this PR is easier to read / understand -- string parsing in code is notoriously non-trivial to understand either
There was a problem hiding this comment.
Agree. I like your #907 🤜
There was a problem hiding this comment.
TBH, I don't think the code of this PR is easier to read / understand -- string parsing in code is notoriously non-trivial to understand either
TBH I'm exhausted to write this PR🤣
|
I think #907 is better for this - not as clean output, but more guaranteed |
Try to fix #902